-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements and more #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rule: property visibility mismatch
… only runs on properties where either the property or internalProperty decorator is used
…Fix problems when emitting component based diagnostics
…ort-path Improve codefix for 'no-missing-import' rule.
Make maxInternalDepth and maxExternalDepth configurable.
…and 'no-property-visibility-mismatch' to 'warning'
runem
changed the title
[WIP] Performance improvements and more
WIP: Performance improvements and more
Jul 14, 2020
…d under some circumstances
…ed into vscode plugin options
runem
changed the title
WIP: Performance improvements and more
Performance improvements and more
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108, closes #103, closes #70, closes #84, closes #90, closes #73, closes #79, closes #66, closes #55, closes #52, closes #53, closes #89, closes #81
Added
no-property-visibility-mismatch
. This rule will ensure public properties use@property
and non-public properties use@internalProperty
(#100)no-missing-element-type-definition
This rule will ensure that custom elements are registered on theHTMLElementTagNameMap
Typescript interface (#73)-1
is used, dependencies will be followed infinitely deep. This can be configured for both external dependencies and project dependencies withmaxNodeModuleImportDepth
&maxProjectImportDepth
(#116)HTMLElementTagNameMap
it's now also possible extend theHTMLElementEventMap
interface and theHTMLElement
interface (#53)Example:
Example:
Fixed and changed
is-assignable-in-boolean-binding
now also accepts "null" and "undefined" types in boolean bindings. Example:<input ?required="${undefined}" />
-
no-unknown-property-converter
has been removed andno-incompatible-property-type
can be used instead.lit-plugin([RULE_ID])
and have unique diagnostic codes (#108)Project
lit-analyzer
now uses data fromvscode-web-custom-data
cancellationToken
is now supported to prevent long running operations