Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated empty-hands-indicator plugin #7676

Merged
merged 9 commits into from
Mar 22, 2025
Merged

Conversation

ciaagent
Copy link
Contributor

Added the ability for the user to get notified when their hands are empty.
Fixed local player being outlined if empty handed and a part of a clan.

Adam-Seyedmortaza and others added 8 commits March 7, 2025 00:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…mpty.

Fixed local player being outlined if empty handed and a part of a clan.
@runelite-github-app
Copy link

runelite-github-app bot commented Mar 20, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Mar 20, 2025

Internal use only: Reviewer details Maintainer details

@tylerwgrass
Copy link
Member

Please remove this overlay on shutdown: https://github.com/ciaagent/Empty-Hands-Indicator/blob/master/src/main/java/emptyhandsindicator/EmptyHandsIndicatorPlugin.java#L68

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 20, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 20, 2025
@ciaagent
Copy link
Contributor Author

Good catch! Done.

@LlemonDuck LlemonDuck merged commit 98ea8c5 into runelite:master Mar 22, 2025
3 checks passed
Sharpienero pushed a commit to Sharpienero/plugin-hub that referenced this pull request Mar 24, 2025
* Added empty-hands-indicator

* Updated empty-hands-indicator plugin

* Updated empty-hands-indicator plugin

* Addressed feedback reverting config group name and applying optimizations.

* Added the ability for the user to get notified when their hands are empty.
Fixed local player being outlined if empty handed and a part of a clan.

* Address PR feedback removing overlay on shutdown

---------

Co-authored-by: Adam Seyedmortaza <adam@seyedmortaza.com>
Sharpienero pushed a commit to Sharpienero/plugin-hub that referenced this pull request Mar 24, 2025
* Added empty-hands-indicator

* Updated empty-hands-indicator plugin

* Updated empty-hands-indicator plugin

* Addressed feedback reverting config group name and applying optimizations.

* Added the ability for the user to get notified when their hands are empty.
Fixed local player being outlined if empty handed and a part of a clan.

* Address PR feedback removing overlay on shutdown

---------

Co-authored-by: Adam Seyedmortaza <adam@seyedmortaza.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants