store and expose public constants in the unit (fixes #316) #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udoprog
reviewed
Nov 15, 2021
udoprog
reviewed
Nov 15, 2021
udoprog
reviewed
Nov 15, 2021
udoprog
reviewed
Nov 15, 2021
tests/tests/unit_constants.rs
Outdated
| let mut sources = rune::sources! { | ||
| entry => { | ||
| mod inner { | ||
| pub const LEET = 1337; |
There was a problem hiding this comment.
Accidental tab (and a few more places)?
Co-authored-by: John-John Tedro <[email protected]>
udoprog
approved these changes
Nov 17, 2021
|
You've just closed it when I was testing! No worries, works like a charm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pkolaczk Please give this branch a try! There's a new
Hash::constantthat can be used to make it clearer, as well.