Remove a bunch of unecessary internal reference counting #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udoprog
force-pushed
the
query-refactor
branch
2 times, most recently
from
81572d2 to
e25125f
Compare
udoprog
force-pushed
the
query-refactor
branch
from
e25125f to
a6f83eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is another big one, and it changes how macros are written.
Macros after this change takes an explicit
ctxargument with the type&mut MacroContext<'_>. This context provides access to everything you need in order to implement a macro and used to be provided through TLS.The TLS has been removed, and as a result it's not possible to remove internal reference counting and RefCell for
Query,Storage, andConstsbecause the lifetime of these can be handled in Rust directly instead.