Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade nanorand to 0.5.2 #243

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Conversation

tgolsson
Copy link
Contributor

@tgolsson tgolsson commented Jan 6, 2021

nanorand generates incorrect random numbers before 0.5.1, see RUSTSEC-2020-0089. It also doesn't support generating signed numbers any more, so this PR adds a workaround for that.

nanorand generates incorrect random numbers before 0.5.1, see
RUSTSEC-2020-0089. It also doesn't support generating signed numbers any
more, so this PR adds a workaround for that.
@tgolsson tgolsson requested a review from udoprog January 6, 2021 14:05
@tgolsson tgolsson added the bug Something isn't working label Jan 6, 2021
@udoprog
Copy link
Collaborator

udoprog commented Jan 6, 2021

Thanks!

Might be worth to use rand at least by default. Even if we don't provide much of a stability guarantee at the moment, it's currently a more vetted alternative. And it's already included as a transitive dependency.

@udoprog udoprog merged commit cdc855e into rune-rs:main Jan 6, 2021
@tgolsson
Copy link
Contributor Author

tgolsson commented Jan 6, 2021

@udoprog Where did you find rand in the dependency tree?

➜ cargo tree | grep rand
│   │   ├── nanorand v0.5.2
│   │   │   └── getrandom v0.2.0

@udoprog
Copy link
Collaborator

udoprog commented Jan 6, 2021

@udoprog Where did you find rand in the dependency tree?

➜ cargo tree | grep rand
│   │   ├── nanorand v0.5.2
│   │   │   └── getrandom v0.2.0

Oh. I thought it was part of the reqwest dependency tree. I guess not!

@udoprog udoprog added the changelog Issue has been added to the changelog label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog Issue has been added to the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants