Rework how protocol functions are called #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows them to be called more flexibly, and for the `string_debug` case avoids the need to allocate a local string buffer internally when debug formatting. Unfortunately this means the `fmt::Debug` impl suffers a bit in that it duplicates `string_debug`. There's just no way to punt a `fmt::Formatter` into a `String`, and since it has a lifetime it can't be called through rune interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows them to be called more flexibly, and for the
string_debugcase avoids the need to allocate a local string buffer internally when
debug formatting.
Unfortunately this means the
fmt::Debugimpl suffers a bit in that itduplicates
string_debug. There's just no way to punt afmt::Formatterinto aString, and since it has a lifetime it can'tbe called through rune interfaces.