Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AoC Day 5 changes #203

Merged
merged 3 commits into from
Dec 7, 2020
Merged

AoC Day 5 changes #203

merged 3 commits into from
Dec 7, 2020

Conversation

udoprog
Copy link
Collaborator

@udoprog udoprog commented Dec 7, 2020 •
edited
Loading

Fixes

  • Bug in how the panic macro was expanded. It was expanded to ::std::core::panic, while the function has been moved to ::std::panic.
  • Bug in how internal eq operation worked for values. Option kinds which weren't equal errored instead of returned false.

APIs:

  • Modified String::split to be able to take different kinds of arguments.
  • Added getter / setter for Range::start / Range::end.

@udoprog udoprog added bug Something isn't working enhancement New feature or request labels Dec 7, 2020
@udoprog udoprog merged commit 25b7f05 into main Dec 7, 2020
@udoprog udoprog deleted the aoc5 branch December 7, 2020 16:01
@udoprog udoprog added the changelog Issue has been added to the changelog label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working changelog Issue has been added to the changelog enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@udoprog