Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit changes the
Args::count
method to take a self parameter, as the size for a Vector can not be known at compile-time like the size of tuples. Hopefully, such a change won't cause worse optimization for tuples as allArgs
are used as generic parameters and so are known what they are compile-time.The second commit implements Args for a
Vec<runestick::Value>
, as well as adding an example of it being used. The use-case for this is when you want to pass parameters of an unknown amount into a rune function.This could be changed to be more generic instead, such as implementing
Args
forVec<T> where T: ToValue
. That would includeValue
, and other Vectors of types which could be transformed into values. If you'd prefer, I could change the pr to implement it forT: ToValue
.