Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up macro spans and introduce format! macro #143

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Clean up macro spans and introduce format! macro #143

merged 1 commit into from
Oct 9, 2020

Conversation

udoprog
Copy link
Collaborator

@udoprog udoprog commented Oct 9, 2020 •
edited
Loading

This adjusts the spans of tokens generated by macros to match the macro itself, to fix errors like these:
image

Are now instead correctly reported like this:
image

Also introduces the format! macro and using it as groundwork for testing format specifications.

@udoprog udoprog added enhancement New feature or request bug Something isn't working labels Oct 9, 2020
@udoprog udoprog merged commit ccee097 into master Oct 9, 2020
@udoprog udoprog deleted the more-macros branch October 9, 2020 08:48
@udoprog udoprog added the changelog Issue has been added to the changelog label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working changelog Issue has been added to the changelog enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@udoprog