Improve the ergonomics of parsing and peeking #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accomplished through a bunch of new codegen in
tools/generate
, a couple of token markers and improved parser buffering.The two primary macros added are:
T
, which will produce the ast type for the given fragment. For example,T![==]
givesast::EqEq
.K
, which produces the token kind of the given fragment. For examples,K![==]
givesast::Kind::EqEq
.These are less error prone and more compact than their
ast::*
equivalents because they visualize what the produced ast means, like:Instead of:
The
Parser
has also been modified to for improved peeking usingPeeker
and its associatednth
method, which allows for peeking as many tokens as necessary forward using a circular buffer.New
Peek
impls look like this: