Replace import iteration with dead code elimination during imports #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
verify_imports
stage of compilation by integrating imports into the indexing/build system.It's still kinda iffily integrated, in that the
get_imports
handling is done separately fromquery_meta
. This is because imports can have cycles, andquery_meta
just doesn't have the necessary plumbing to deal with it. There's also a fair amount of metadata that would have to be awkwardly propagated (like import chains used for diagnostics), so it might not be worth it.This is what cyclic import checking looks like right now:
