Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer parsing of items and expressions to their enum implementation #121

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

udoprog
Copy link
Collaborator

@udoprog udoprog commented Sep 28, 2020

This defers parsing of all Expr* and Item* types to their corresponding Expr and Item enums. This provides better diagnostics when these are used in macros, and since the parsing is nontrivial it avoids the complexity of having to reimplement contextual parsing in each item and expression type.

@udoprog udoprog added enhancement New feature or request parser Issues related to parsing. labels Sep 28, 2020
@udoprog udoprog merged commit f6f7048 into master Sep 28, 2020
@udoprog udoprog deleted the defer-parsing branch September 28, 2020 12:21
@udoprog udoprog added the changelog Issue has been added to the changelog label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Issue has been added to the changelog enhancement New feature or request parser Issues related to parsing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant