Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce IrError as its own interpreter error #108

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Introduce IrError as its own interpreter error #108

merged 1 commit into from
Sep 25, 2020

Conversation

udoprog
Copy link
Collaborator

@udoprog udoprog commented Sep 25, 2020 •
edited
Loading

This breaks an awkward overuse of CompileError by introducing QueryError and IrError:

  • QueryError are errors raised when serving a compiler query.
  • IrError are errors raised when running the ir interpreter. This use to mostly be covered by CompileError::const_error, but if we want to provide better diagnostics on error it needs more specific error kinds.

@udoprog udoprog added the enhancement New feature or request label Sep 25, 2020
@udoprog udoprog merged commit 709412c into master Sep 25, 2020
@udoprog udoprog deleted the ir-error branch September 25, 2020 03:51
@udoprog udoprog added the changelog Issue has been added to the changelog label Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog Issue has been added to the changelog enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@udoprog