Add the rand module
#100
Merged
Add the rand module
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2020 14:53
revert(modules): Remove `byte`/`byte_range` functions chore: Add `rand` example script
udoprog
requested changes
Sep 22, 2020
There was a problem hiding this comment.
Module looks great. Could you remove and .gitignore the .idea files?
My impression of IntelliJ is that it does just fine importing projects. And I won't be able to keep them up-to-date seeing as I don't use it. It's different with e.g. .vscode/launch.json, since this is just a generic launch configuration. But an incomplete .idea project listing seems like it could cause editor confusion!
|
Also looking forward to #73, so we can get somewhere to put api docs :). |
udoprog
reviewed
Sep 22, 2020
| } | ||
|
|
||
| /// Generate a random integer | ||
| fn int(&mut self) -> Value { |
There was a problem hiding this comment.
FTR, these can simply return i64. Conversion is handled by Rune (for any type implementing the ToValue trait). Returning a Value doesn't hurt though!
udoprog
approved these changes
Sep 22, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
randmodule.Exposes two types:
rand::WyRandandrand::Pcg64, which are RNGs. Each has the following functions:int() -> Integerandint_range(lower: Integer, upper: Integer) -> IntegerIn addition,
rand::int[_range]exposes a single-use WyRand generator