Allow pinning vm's machine image, instead of always using latest …stable/cos_cloud #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennislapchenko
force-pushed
the
pin_machine_image
branch
from
19084e2 to
e7a3dfb
Compare
dennislapchenko
force-pushed
the
pin_machine_image
branch
from
e7a3dfb to
9ba6a75
Compare
|
Thanks for this PR 🙌 @dennislapchenko, currently on a trip - I'm back in 2 days! |
|
@bschaatsbergen so hopefully you will merge this in the coming days? On Monday is my last day at the place where I implemented this, would like to wean them off my personal fork before leaving 😁 |
|
Jumping on it now @dennislapchenko ! |
|
I would think that something like I did in #99 would be a good idea. You give the user the ability to overwrite the entire disk source image if they want too, or let them specify a specific COS version, or get the latest stable COS image. @dennislapchenko - thoughts? |
bschaatsbergen
added
patch
|
@bschaatsbergen agree this was the least confusing way. Thanks for finalising this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
fullimage name needs to be passed everytime. After the second commit you can just provide the short name and it will be verified. One drawback is that this it's not possible to move away from cos images, which probably is not desired anyway.why
cosimages work well with atlantis/secure vm configurations.. Just today i was making tweaks to the module and latest image got deployed too. As a result backend never could be reached.. could not find any logs as to why this happened, but reverting the image instantly fixed the issue.