Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: remove project from google_iap_client #106

Merged
merged 1 commit into from
Mar 13, 2023
Merged

examples: remove project from google_iap_client #106

merged 1 commit into from
Mar 13, 2023

Conversation

tpolekhin
Copy link
Contributor 

╷
│ Error: Unsupported argument
│
│   on modules/atlantis/iap.tf line 16, in resource "google_iap_client" "atlantis":
│   16:   project      = var.project_id
│
│ An argument named "project" is not expected here.
╵

what

A small change to IAP example I found during my deployment

why

To make it work

references

  • Use Closes #123, if this PR closes a GitHub issue #123
  • If possible, link to the relevant documentation to add some context.

@tpolekhin
examples: remove project from google_iap_client
70e98de 
An argument named "project" is not expected here.
bschaatsbergen
bschaatsbergen approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bschaatsbergen bschaatsbergen added bug Something isn't working minor New features that doesn't break anything labels Mar 13, 2023
@bschaatsbergen
Copy link
Member

bschaatsbergen commented Mar 13, 2023 •
edited
Loading

Thanks for your contribution @tpolekhin 👏🏼

@bschaatsbergen bschaatsbergen merged commit b49d1ca into runatlantis:main Mar 13, 2023
@tpolekhin tpolekhin deleted the patch-1 branch March 13, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschaatsbergen bschaatsbergen bschaatsbergen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working minor New features that doesn't break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpolekhin @bschaatsbergen