Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore casing on log levels #976

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Conversation

jpreese
Copy link
Contributor

@jpreese jpreese commented Apr 4, 2020

Just a small quality of life change when parsing log levels. During our rollout of Atlantis, I had set the log level to DEBUG and saw it wasn't a valid option.

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #976 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   72.12%   72.14%   +0.02%     
==========================================
  Files          65       65              
  Lines        5316     5321       +5     
==========================================
+ Hits         3834     3839       +5     
  Misses       1186     1186              
  Partials      296      296              
Impacted Files Coverage Δ
cmd/server.go 79.72% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548fe5f...f51be62. Read the comment docs.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small comment.

cmd/server.go Outdated Show resolved Hide resolved
@lkysow lkysow merged commit df357bd into runatlantis:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants