Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow modified files to be excluded #847

Conversation

leonsodhi-lf
Copy link

I noticed that setting when_modified to something like ["*.tf", "!exclude-me.tf] with a modified list of exclude-me.tf still resulted in a plan automatically running. This PR allows files to be excluded using .dockerignore's exclusion syntax, i.e. prepending a ! to the path.

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #847 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   71.83%   71.88%   +0.04%     
==========================================
  Files          65       65              
  Lines        5213     5221       +8     
==========================================
+ Hits         3745     3753       +8     
  Misses       1183     1183              
  Partials      285      285
Impacted Files Coverage Δ
server/events/project_finder.go 94.38% <100%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e8e29...1965d76. Read the comment docs.

@lkysow
Copy link
Member

lkysow commented Nov 27, 2019

I carried your commits to #865. Thanks for the great fix!

@lkysow lkysow closed this Nov 27, 2019
@leonsodhi-lf leonsodhi-lf deleted the support-docker-ignore-exceptions branch November 27, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants