Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include errored cmd output twice. #619

Merged
merged 1 commit into from
May 7, 2019
Merged

Don't include errored cmd output twice. #619

merged 1 commit into from
May 7, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented May 7, 2019

Since we're including the command output inside the error, we don't need
to also return the output. This was resulting in the error output being
printed twice.

Fixes #519

Since we're including the command output inside the error, we don't need
to also return the output. This was resulting in the error output being
printed twice.
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #619 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
- Coverage   72.17%   72.15%   -0.03%     
==========================================
  Files          61       61              
  Lines        4633     4629       -4     
==========================================
- Hits         3344     3340       -4     
  Misses       1044     1044              
  Partials      245      245
Impacted Files Coverage Δ
server/events/runtime/run_step_runner.go 100% <100%> (ø) ⬆️
server/events/models/models.go 73.98% <0%> (-0.62%) ⬇️
server/events/working_dir.go 74.69% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c01ea...e45bc33. Read the comment docs.

@lkysow lkysow merged commit 3160a82 into master May 7, 2019
@lkysow lkysow deleted the double-error branch May 7, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom workflow run commands comment twice on PRs when command returns an error
1 participant