fix: Resolve Rendering Issue in the Policy Check Results Template #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorian-tsorfy
requested review from
GenPage,
lukemassa and
nitrocode
and removed request for
a team
|
@X-Guardian, |
|
@jamengual Hi |
|
Thanks @dorian-tsorfy, can you check this comment to see whether further fixes are needed: #4623 (comment) |
Done |
|
@GenPage @jamengual |
chenrui333
approved these changes
Sep 2, 2024
X-Guardian
changed the title
1 task
a1k0u
pushed a commit
to a1k0u/atlantis
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
I added a space line to the
policy_check_results_wrapped.tmplfile so the output on GitLab will look nice.Resolving issue #4623.
why
We have noticed intermittent issues rendering the markdown Atlantis outputs to GitLab when a policy check failure occurs ever since upgrading from v0.27.3 to v0.28.1. I suspect this could be related to #4254 and the formatting changes it made.
tests
references
#4623
#4787