fix: add app to the github app installation id #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdellegrazie
requested review from
jamengual,
lukemassa and
X-Guardian
and removed request for
a team
github-actions
bot
added
docs
|
@jamengual this is the additional PR discussed in #4579 |
|
@chenrui333 / @jamengual there's a test failure related to a lock file restriction but I haven't changed anything in this area - it's a required CI pass though so can anyone help here? |
bdellegrazie
force-pushed
the
fix/github-app-installation-id
branch
from
b3d6685
to
3214a72
Compare
|
agree, I need to fix the issue first. |
bdellegrazie
force-pushed
the
fix/github-app-installation-id
branch
from
3214a72
to
5f40d8a
Compare
|
I have fixed the tests per #4653 refreshed the pr and rerun |
|
@bdellegrazie Thanks for your first contribution to atlantis!! 🎉 |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
A tiny fix to correct the terminology used for the Github App Installation ID so it includes "App" as does the rest of the Github App configuration items.
This is a trivial PR to build on @john-tipper 's fine work - it's not intended to devalue the serious effort made to address the original requirement (thank you!)
why
purely for naming consistency and ease of use.
tests
Existing tests updated to use the new name.
Documentation updated too.
references
fixes #4579