Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix navbar issue #4521

Merged
merged 3 commits into from
May 8, 2024
Merged

docs: fix navbar issue #4521

merged 3 commits into from
May 8, 2024

Conversation

chenrui333
Copy link
Member

fix site

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 marked this pull request as ready for review May 8, 2024 15:52
@chenrui333 chenrui333 requested review from a team as code owners May 8, 2024 15:52
@chenrui333 chenrui333 requested review from GenPage, lukemassa and X-Guardian and removed request for a team May 8, 2024 15:52
@chenrui333
Copy link
Member Author

my local spin up also works fine now

image

sitemap: 7.1.1
vuepress: 2.0.0-rc.9(@vuepress/[email protected])([email protected])
transitivePeerDependencies:
- typescript
dev: true

/@vuepress/[email protected]([email protected]):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the key change, theme-data has some issue

image

Signed-off-by: Rui Chen <[email protected]>
@chenrui333
Copy link
Member Author

chenrui333 commented May 8, 2024

@chenrui333 chenrui333 changed the title docs: fix site (revert to c8e49bb4aab2856059ab4cf04afedc92738205a0) docs: fix navbar issue May 8, 2024
@chenrui333 chenrui333 changed the title docs: fix navbar issue website: fix navbar issue May 8, 2024
@chenrui333 chenrui333 changed the title website: fix navbar issue docs: fix navbar issue May 8, 2024
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tjhanks @chenrui333

@chenrui333 chenrui333 merged commit 454fc72 into main May 8, 2024
25 of 27 checks passed
@chenrui333 chenrui333 deleted the try-fix-site branch May 8, 2024 16:09
@chenrui333
Copy link
Member Author

relates to #4515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants