fix: improve git error log while running 'atlantis apply' #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmokijewski
requested review from
GenPage,
lukemassa and
nitrocode
and removed request for
a team
mmokijewski
changed the title
nitrocode
reviewed
Jan 26, 2024
GenPage
added
feature
lukemassa
previously approved these changes
Jan 27, 2024
lukemassa
approved these changes
Jan 31, 2024
nitrocode
approved these changes
Feb 2, 2024
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
Dummy comment to add some activity |
|
/cherry-pick release-0.27 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
…ommitting user) (#4177)
GenPage
pushed a commit
that referenced
this pull request
Mar 8, 2024
…ommitting user) (#4177) (#4324) Co-authored-by: mmokijewski <[email protected]>
chenrui333
removed
feature
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Improve error message printed by atlantis in case of errors coming from
git ls-files . --otherscommand when callingatlantis applywhy
For make debugging easier. My case was that I had defined Terragrunt cache directory (which is not git repository) just parallel to workspace directories. At first glance it was not obvious seeing such error what is going about, but after take a look in source code I found what exactly atlantis does under the hood. Improved error message could make cause finding much faster.
tests
Added unit test on previously uncovered code
references
It may also be helpful by debugging already existing issues like e.g. #2168 or #3139