chore: fix label type in gitlab testdata #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
X-Guardian
approved these changes
Dec 22, 2023
|
/cherry-pick release-0.27 |
lukemassa
added a commit
that referenced
this pull request
Jan 19, 2024
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Change type of
labelsfrom string to array in gitlab test data.why
Debugging why unit tests on #4028 are failing, it turns out that label parsing was updated in
0.95such that the empty string is failing:This doesn't appear to correspond to any actual changes in the API, so I don't think any non-test code needs to be updated, it's just whenever this testdata was written it was filled in with the wrong type. If you look even now at an MR in the gitlab API, you'll see it's an empty array, not an empty string:
tests
Running unit tests in #4028 and noting that it passes where it failed before.
references
Makes #4028 pass