fix: ensure the MR log line prints an integer and not a rune #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Andersen <[email protected]>
jandersen-plaid
requested review from
jamengual,
lukemassa and
nitrocode
and removed request for
a team
lukemassa
approved these changes
Dec 19, 2023
|
/cherry-pick release-0.27 |
lukemassa
pushed a commit
to lukemassa/atlantis
that referenced
this pull request
Dec 19, 2023
…ntis#4078) Signed-off-by: Jack Andersen <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…ntis#4078) Signed-off-by: Jack Andersen <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…ntis#4078) Signed-off-by: Jack Andersen <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This changes the log line for projects changed on MR to print an integer instead of a character literal.
why
%qprints out a a single-quoted character literal safely escaped with Go syntax. when given an integer for formatting. This results in log lines that look like:or are completely empty. This changes the format string from
%qto%dso that an integer is printed instead of a character literal.tests
I have run atlantis locally and verified the log output.
references