Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre plan output being removed. #367

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Fix pre plan output being removed. #367

merged 1 commit into from
Nov 30, 2018

Commits on Nov 30, 2018

  1. Fix pre plan output being removed.

    Prior to this change, we were formatting the output from terraform plan
    inside the markdown_renderer. Part of this formatting is to remove all
    output relating to refreshing state. The way we were doing this was to
    simply delete all lines before the refreshing completes.
    
    The problem with this approach was that any output from custom steps
    that ran before plan would also be deleted. This change moves the
    formatting of the plan output inside the plan step. Then the
    markdown_renderer deals with the pre-formatted output and doesn't need
    to delete anything before it combines all the step outputs into one.
    lkysow committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    70d1948 View commit details
    Browse the repository at this point in the history