chore: Fix Go Static Check Errors

[X-Guardian]

what

Fix the following Go static check errors:

{
	"resource": "server/events/github_app_working_dir_test.go",
	"message": "package \"github.com/petergtz/pegomock/v4\" is being imported more than once (ST1019)\n\tgithub_app_working_dir_test.go:8:2: other import of \"github.com/petergtz/pegomock/v4\"",
	"startLineNumber": 7,
},{
	"resource": "server/events/plan_command_runner_test.go",
	"message": "type RepoModel is unused (U1000)",
	"startLineNumber": 499,
},{
	"resource": "server/events/project_command_builder.go",
	"message": "*&x will be simplified to x. It will not copy x. (SA4001)",
	"startLineNumber": 737,
},{
	"resource": "server/events/project_command_context_builder.go",
	"message": "should omit comparison to bool constant, can be simplified to prjCfg.PolicyCheck (S1002)",
	"startLineNumber": 197,
},{
	"resource": "server/events/project_finder.go",
	"message": "pm.Matches is deprecated: This implementation is buggy (it only checks a single parent dir against the pattern) and will be removed soon. Use either MatchesOrParentMatches or MatchesUsingParentResults instead.  (SA1019)",
	"startLineNumber": 227,
	"startColumn": 18,
},{
	"resource": "server/events/project_finder.go",
	"message": "patternMatcher.Matches is deprecated: This implementation is buggy (it only checks a single parent dir against the pattern) and will be removed soon. Use either MatchesOrParentMatches or MatchesUsingParentResults instead.  (SA1019)",
	"startLineNumber": 269,
},{
	"resource": "server/events/working_dir_locker.go",
	"message": "error strings should not be capitalized (ST1005)",
	"startLineNumber": 66,
},{
	"resource": "server/events/working_dir_locker.go",
	"message": "error strings should not end with punctuation or newlines (ST1005)",
	"startLineNumber": 66,
},{
	"resource": "server/events/working_dir_locker.go",
	"severity": 4,
	"message": "error strings should not be capitalized (ST1005)",
	"startLineNumber": 85,
},{
	"resource": "server/events/working_dir_locker.go",
	"message": "error strings should not end with punctuation or newlines (ST1005)",
	"startLineNumber": 85,
}

Also fixed the working dir locker tests after the error string change.

why

Improve code quality

references

• https://staticcheck.dev/

[jamengual]

is the test error expected @X-Guardian ?

[X-Guardian]

No @jamengual, I need to investigate whether there is an issue with one of these fixes, or whether they have exposed a bug.

[GenPage]

The failure is due to the working_dir formatting changes:

--- FAIL: TestTryLock (0.00s)
working_dir_locker_test.go:36: exp err: "The default workspace at path . is currently locked by another command that is running for this pull request.
Wait until the previous command is complete and try again." 
but got: "the default workspace at path . is currently locked by another command that is running for this pull request.
Wait until the previous command is complete and try again"

[X-Guardian]

Thanks @GenPage, I was assuming it was something more complex.

Test updated.

[GenPage]

Thank you @X-Guardian, this was much needed