Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): link_check required #3633

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix(ci): link_check required #3633

merged 1 commit into from
Jul 28, 2023

Conversation

GenPage
Copy link
Member

@GenPage GenPage commented Jul 28, 2023 •
edited
Loading

what

  • This needs to match up with the website / link_check

why

If it doesn't, it won't allow non-website related JS files to block PRs

tests

  • I have tested my changes by checking CI as the tests shows properly instead of just website_check

references

@GenPage GenPage requested a review from a team as a code owner July 28, 2023 19:23
@jamengual jamengual merged commit 99c3a01 into main Jul 28, 2023
@jamengual jamengual deleted the fix-ci-website-link-check-required branch July 28, 2023 19:27
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@GenPage @ijames-gc
fix(ci): link_check required (runatlantis#3633)
52cf482
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@GenPage @ijames-gc
fix(ci): link_check required (runatlantis#3633)
53629de
terakoya76 pushed a commit to terakoya76/atlantis that referenced this pull request Dec 31, 2024
@GenPage @terakoya76
fix(ci): link_check required (runatlantis#3633)
f28f880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
github-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GenPage @jamengual