fix: Atlantis Triggers AutoPlans on Non-Code Change GitLab Merge Event Webhooks #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n/atlantis into gitlab-merge-event-fix
|
Maintainers, this PR is ready for review. |
jamengual
approved these changes
Jul 6, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…t Webhooks (runatlantis#3567) * Gitlab merge event fix * Update events controller tests * Update eventrsController formatting * Update events controller test formatting * Revert gitlab_request_parser_validator * Update event_parser * Update tests * Add new testdata * Add testdata EOF LF * Update gitlab-merge-request-event-update-reviewer.json * Update gitlab-merge-request-event-update-milestone.json
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…t Webhooks (runatlantis#3567) * Gitlab merge event fix * Update events controller tests * Update eventrsController formatting * Update events controller test formatting * Revert gitlab_request_parser_validator * Update event_parser * Update tests * Add new testdata * Add testdata EOF LF * Update gitlab-merge-request-event-update-reviewer.json * Update gitlab-merge-request-event-update-milestone.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Updates the
ParseGitlabMergeRequestUpdateEventfunction to returnmodels.OtherPullEventifObjectAttributes.OldRevdoesn't exist.Also updated the GitLab 'update target branch' test, as this doesn't have a code change so shouldn't return
models.UpdatedPullEvent.why
tests
Tested locally