Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update access-credentials.md #3506

Merged
merged 3 commits into from
Jun 10, 2023

Conversation

kevin-fitlg
Copy link
Contributor

@kevin-fitlg kevin-fitlg commented Jun 9, 2023

what

This PR updates the documentation to clarify there is no need to have manual webhooks created when using GitHub App method.

why

It is not clear that you don't need a webook with GitHub App and users might create that when setting up Atlantis. This leads to locking errors on Atlantis server.

tests

references

@kevin-fitlg kevin-fitlg requested a review from a team as a code owner June 9, 2023 12:51
@github-actions github-actions bot added the docs Documentation label Jun 9, 2023
@nitrocode nitrocode added this to the v0.24.3 milestone Jun 10, 2023
@nitrocode nitrocode merged commit 3d5786c into runatlantis:main Jun 10, 2023
@nitrocode
Copy link
Member

Thank you!

mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
* Update access-credentials.md

* Update access-credentials.md

* Update runatlantis.io/docs/access-credentials.md

---------

Co-authored-by: nitrocode <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* Update access-credentials.md

* Update access-credentials.md

* Update runatlantis.io/docs/access-credentials.md

---------

Co-authored-by: nitrocode <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* Update access-credentials.md

* Update access-credentials.md

* Update runatlantis.io/docs/access-credentials.md

---------

Co-authored-by: nitrocode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants