Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: function docs, linting errors #3380

Merged
merged 7 commits into from
Jun 20, 2023
Merged

chore: function docs, linting errors #3380

merged 7 commits into from
Jun 20, 2023

Conversation

pkaramol
Copy link
Contributor

@pkaramol pkaramol commented May 6, 2023 •
edited by nitrocode
Loading

what

This PR:

  • adds a function documentation (more to be added as I go through the code); hopefully to make things easier for future contributors
  • fixes 2 linting errors by removing 2 unused (named) function arguments

why

tests

No functionality changes, no tests needed to run.

references

@pkaramol pkaramol requested a review from a team as a code owner May 6, 2023 12:14
@github-actions github-actions bot added the go Pull requests that update Go code label May 6, 2023
@github-actions github-actions bot added the build Relating to how we build Atlantis label May 6, 2023
@pkaramol pkaramol changed the title Function documentation and linting errors Function documentation, linting errors, ca-certificates version update for alpine May 6, 2023
@github-actions github-actions bot removed the build Relating to how we build Atlantis label May 7, 2023
@nitrocode nitrocode changed the title Function documentation, linting errors, ca-certificates version update for alpine chore: function docs, linting errors May 7, 2023
@GenPage GenPage added the waiting-on-review Waiting for a review from a maintainer label May 13, 2023
@GenPage GenPage merged commit 8514255 into runatlantis:main Jun 20, 2023
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
@pkaramol @pantelis-karamolegkos @nitrocode
chore: function docs, linting errors (runatlantis#3380)
903fda4 
* Function documentation and linting errors

---------

Co-authored-by: Pantelis Karamolegkos <[email protected]>
Co-authored-by: nitrocode <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@pkaramol @pantelis-karamolegkos
@nitrocode @ijames-gc
chore: function docs, linting errors (runatlantis#3380)
59940e6 
* Function documentation and linting errors

---------

Co-authored-by: Pantelis Karamolegkos <[email protected]>
Co-authored-by: nitrocode <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@pkaramol @pantelis-karamolegkos
@nitrocode @ijames-gc
chore: function docs, linting errors (runatlantis#3380)
6b6c794 
* Function documentation and linting errors

---------

Co-authored-by: Pantelis Karamolegkos <[email protected]>
Co-authored-by: nitrocode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GenPage GenPage GenPage approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkaramol @GenPage @pantelis-karamolegkos @nitrocode