Make project locked message look better. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some of the tests run git so if you're using gpg signing you need to disable that. - refactor test helpers to use tb.Helper() and make the error output red. This is useful because if another helper uses one of these helpers, when it calls .Helper() its output will also be up the stack.
When the plan fails, it gets the error prepended with **Plan Failed**:. Thus we don't need to add our own "**Unable to run plan**" error.
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 61 61
Lines 3643 3643
=======================================
Hits 2571 2571
Misses 893 893
Partials 179 179
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the plan fails, it gets the error prepended with Plan Failed:.
Thus we don't need to add our own "Unable to run plan" error.
Some cleanup from #325