feat(executable-name): Add check for misspelled comment command #3059
+91
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbighead
force-pushed
the
atlantis-misspell
branch
2 times, most recently
from
dff5c42 to
a1d5c24
Compare
ibbadhafeez
approved these changes
Jan 27, 2023
edbighead
force-pushed
the
atlantis-misspell
branch
from
a1d5c24 to
b7e6361
Compare
nitrocode
reviewed
Jan 27, 2023
nitrocode
added
waiting-on-response
edbighead
force-pushed
the
atlantis-misspell
branch
from
b7e6361 to
31e2e26
Compare
edbighead
changed the title
edbighead
force-pushed
the
atlantis-misspell
branch
4 times, most recently
from
0f8ceaf to
f49cb14
Compare
|
hey @nitrocode, I think it's ready for review |
krrrr38
reviewed
Feb 21, 2023
edbighead
force-pushed
the
atlantis-misspell
branch
from
f49cb14 to
c264a83
Compare
edbighead
force-pushed
the
atlantis-misspell
branch
from
c264a83 to
3f4f12a
Compare
krrrr38
reviewed
Feb 21, 2023
Co-authored-by: Ken Kaizu <[email protected]>
nitrocode
approved these changes
Feb 22, 2023
nitrocode
removed
waiting-on-response
nitrocode
changed the title
|
Thank you @edbighead for the contribution! Thank you @krrrr38 for the extra review! |
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
) * feat: Add check for misspelled executable name command * Update server/utils/spellcheck_test.go Co-authored-by: Ken Kaizu <[email protected]> --------- Co-authored-by: nitrocode <[email protected]> Co-authored-by: Ken Kaizu <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
) * feat: Add check for misspelled executable name command * Update server/utils/spellcheck_test.go Co-authored-by: Ken Kaizu <[email protected]> --------- Co-authored-by: nitrocode <[email protected]> Co-authored-by: Ken Kaizu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add spellcheck for executable name
why
Sometimes users misspell
atlantisword and are waiting for their PR to be applied. Decided to go with terraform approach and use https://github.com/agext/levenshteintests
Added unit tests and tested on my local atlantis server:
https://github.com/bighead-io/applications/pull/5#issuecomment-1436949866
(running atlantis under my personal user here)
references
Closes #3069