Removing web credentials from debug log #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
approved these changes
Feb 17, 2022
|
@pkaramol We have been talking to other atlantis developers and we think that we should remove the output of the user and pass entirely from the logs, we do not log credentials in general. Do you think you could remove the login of the creds? |
done; let me know if anything else needs to me modified. |
jamengual
approved these changes
Feb 17, 2022
jamengual
changed the title
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* Hashing web credentials * Fix syntactic error * Using strong cryptogrpahic primitive * Entirely removing credentials * Removing unused constant * Removing redundant formatting parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid plaintext printing of web credentials