Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken Log Streaming URL when working directory is set to "./" #2015

Merged
merged 5 commits into from
Jan 24, 2022

Conversation

Aayyush
Copy link
Contributor

@Aayyush Aayyush commented Jan 24, 2022

We'll eventually be moving to a UUID based log-streaming job identifier, removing any dependencies on the project name or the directory. So, replacing the "." character with a "_" as a temporary fix!

#1993

@Aayyush Aayyush requested a review from a team as a code owner January 24, 2022 20:12
@msarvar msarvar merged commit 7d3f3fb into runatlantis:master Jan 24, 2022
@msarvar msarvar deleted the fix-1993 branch January 24, 2022 20:18
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…unatlantis#2015)

* Replacing . with _ when generating project identifier if project name is not set

* Adding test for GenerateProjectJobURL when working dir set to .

* Replacing . with _ when generating project identifier if project name is not set

* Fixing merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants