Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): allow correct path to be derived for on premise installation #1863

Merged
merged 10 commits into from
Oct 26, 2021

Conversation

dandcg
Copy link
Contributor

@dandcg dandcg commented Oct 18, 2021

This PR allows owner (collection) to be correctly derived for an on premise install of Azure Devops by removing the dependencies on dev.azure.com as hardcoded URL.

I have created separate fixtures and unit tests for self hosted Azure DevOps in case we find anymore variation from the cloud version.

@dandcg dandcg requested a review from a team as a code owner October 18, 2021 12:59
@jamengual
Copy link
Contributor

Please give a detailed description of this pull request, thanks.

@dandcg
Copy link
Contributor Author

dandcg commented Oct 19, 2021

@jamengual I have updated the description. Cheers.

Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acastle acastle merged commit 4248e2e into runatlantis:master Oct 26, 2021
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…ion (runatlantis#1863)

* add .devcontainer to .gitignore

* allow AzureDevOps host to be specified in the user_config

* fix spacing issues

* gofmt

* fixes to cmd and update to approach

* add specific self host fixtures

* add specific self host parser tests

* update code to azure self hosted devops

* go fmt

Co-authored-by: atlantisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants