Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix support for terraform workspaces #1578

Closed

Conversation

monitrue
Copy link

@monitrue monitrue commented May 12, 2021

PR #1363 hardcoded a 3rd-party configuration variable (Terraform's TF_WORKSPACE), breaking terraform workspaces support in Atlantis.

This PR reverts the change made by #1363 to restore support for terraform workspaces. Users wishing to set TF_WORKSPACE to any value including the current workspace name, can easily do so with a custom workflow, or by externally setting the TF_WORKSPACE environment variable system-wide or session-wide.

Please see #1517 for bug report.

@monitrue monitrue requested a review from a team as a code owner May 12, 2021 19:52
@chenrui333 chenrui333 changed the title Bug: fix support for terraform workspaces fix: fix support for terraform workspaces Jul 7, 2021
@keslerm
Copy link

keslerm commented Jul 26, 2021

any chance to get this merged in soon? #1363 has broken almost all our workflows.

@SubNader
Copy link

SubNader commented Jan 7, 2022

Bumping this one more time.

@jamengual
Copy link
Contributor

@monitrue could you fix the conflicts?

@bschaeffer
Copy link
Contributor

@jamengual @monitrue I am 100% ready to resolve the conflicts and fix this up... is that cool? This is a blocker for us as well I think. Unsure how workspaces are supported at all if this prevents workspaces from being used in atlantis...

@jamengual
Copy link
Contributor

@jamengual @monitrue I am 100% ready to resolve the conflicts and fix this up... is that cool? This is a blocker for us as well I think. Unsure how workspaces are supported at all if this prevents workspaces from being used in atlantis...

go for it.

@monitrue
Copy link
Author

@bschaeffer Absolutely mate, go for it! I lost hope that this fix will ever be merged.

bschaeffer added a commit to bschaeffer/atlantis that referenced this pull request Jan 18, 2022
Fixes runatlantis#1517 and basically is a rebased version of runatlantis#1578.
@bschaeffer
Copy link
Contributor

Unsure how to rebase someone else's branch, so just did it in a new PR #2006

jamengual pushed a commit that referenced this pull request Jan 18, 2022
Fixes #1517 and basically is a rebased version of #1578.
@jamengual
Copy link
Contributor

Fixed in #2006

@jamengual jamengual closed this Jan 18, 2022
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants