Reversed if statement for comment splitting #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
approved these changes
Jul 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
+ Coverage 70.91% 71.17% +0.25%
==========================================
Files 71 71
Lines 5876 5876
==========================================
+ Hits 4167 4182 +15
+ Misses 1362 1346 -16
- Partials 347 348 +1
Continue to review full report at Codecov.
|
|
@crainte could you add a unit test that would have caught this? |
|
I can do that, it will be later today/tomorrow though due to work delays. Sorry about the mistakes :( |
crainte
force-pushed
the
fix_for_comment_splitting
branch
from
5a67149
to
1e34107
Compare
crainte
force-pushed
the
fix_for_comment_splitting
branch
from
1e34107
to
4568213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake with my if statement logic for comment splitting.