Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub app #1088

Merged
merged 8 commits into from
Jun 19, 2020
Merged

GitHub app #1088

merged 8 commits into from
Jun 19, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jun 19, 2020

Small refactor to #971

unRob and others added 8 commits June 3, 2020 20:16
@unRob
Play around with github app credentials
199cdfe
@unRob
Upgrade to github/v31 for CompleteAppManifest
227ce9c 
split fixtures out elsewhere, add working dir test
@unRob
Test against a live repo, fix accordingly
011d3f8 
more docs, add installation step
@unRob
enable webhook url, listen to issue_comment event
dffba36
@unRob
listen to pull_request_review*, docs on webhooks
2509240
@unRob
Error out instead of panicking when passed a bad keyfile
13ebeee
@unRob
make fragments lowercase
2b74dc9
@lkysow
Refactoring to github app code
875abf1 
- rename gh-app-key to gh-app-key-file for clarity
- change git credentials writer to append a line if there is an existing
.git-credentials file and in the case of the github app to replace the
old github app line
- removed automatically setting --write-git-creds to true when using a
github app and instead requiring this is set specifically
@codecov
Copy link

codecov bot commented Jun 19, 2020 •
edited
Loading

Codecov Report

Merging #1088 into master will decrease coverage by 1.13%.
The diff coverage is 52.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
- Coverage   71.49%   70.36%   -1.14%     
==========================================
  Files          67       70       +3     
  Lines        5564     5814     +250     
==========================================
+ Hits         3978     4091     +113     
- Misses       1272     1392     +120     
- Partials      314      331      +17
Impacted Files Coverage Δ
server/events/command_runner.go 43.87% <ø> (ø)
server/events/event_parser.go 86.19% <ø> (ø)
server/events_controller.go 57.75% <ø> (ø)
server/github_app_controller.go 0.00% <0.00%> (ø)
server/github_request_validator.go 91.30% <ø> (ø)
server/user_config.go 100.00% <ø> (ø)
server/server.go 59.68% <50.00%> (-2.15%) ⬇️
server/events/github_app_working_dir.go 57.14% <57.14%> (ø)
cmd/server.go 78.69% <63.63%> (-1.04%) ⬇️
server/events/vcs/github_credentials.go 75.34% <75.34%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25cd66d...875abf1. Read the comment docs.

@lkysow lkysow merged commit c70dd5f into master Jun 19, 2020
@lkysow lkysow deleted the github-app branch June 19, 2020 18:48
@unRob unRob mentioned this pull request Aug 6, 2020
Closed
@nitrocode nitrocode mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkysow @unRob