-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BitBucket support #30
Comments
Comment by @tomasquith +1 |
Comment by @hussfelt +1 |
Comment by @lkysow Please add a thumbs up reaction so we can keep the comments about the implementation please! We'll use the reactions to help prioritize. |
Comment by @ashald We would love to have that! Especially, if it will be possible to use it with self-hosted instances as we have one within internal network. |
This would be a huge win for our team, as we are currently planning a migration to bitbucket, and are looking to evaluate this tool, but unfortunately as it is not supported we are unable to evaluate this. Is there a timeline on when this is or will be looked at? |
Hi @MattPumphrey, I'm going to try and get out an alpha of bitbucket this week. I'll keep you updated and thanks for your interest in Atlantis! |
For clarity, would that be about Bitbucket Cloud or Bitbucket Server (aka Stash)? My guess is on the former, but I suggest renaming it for clarity :) |
Good question. After looking into it, Bitbucket Cloud uses the 2.0 REST APIs and is deprecating the 1.0 REST APIs while Bitbucket server only uses the 1.0 apis. This means I'll have to develop the two integrations separately. I think I'll start with Bitbucket Cloud first since there is already a golang client for the 2.0 API. But my intention will be to support both eventually. |
+1 Bitbucket is a huge deal for some of us |
Atlantis 0.4.3 now supports Bitbucket Cloud (bitbucket.org). To use, run
Bitbucket Server (aka Stash) support is in progress: #190 |
@aodj @viggeh @arnarg @jkodroff @ilyalavrenov @scboucher @zytek @hussfelt @angry-cellophane @Aerathis @johananl @luvs @jonnydford @MattPumphrey @joestewart @odedpriva @moxli @hubertusa @djenniex @h-svab @JeanFred @frank-bee @leowmjw @adamcrews @kmfk @beatcracker @stibi @nikita-stuzo @teosoft123 @absenth For more information: If you've got any issues please let me know because it's hard to test out everything. You can join our slack channel here or just post on this ticket. |
@lkysow I started messing around and tried to use the --require-approval flag. I have set the required approvals to merge a pull request via the Branch permissions to two and started atlantis with the flag. If approve a pull request on my own and I am able to run apply (atlantis just checks if there is a single approval), how ever I can not merge the pull requests because I need one more person to approve it. Can you think of any way to make atlantis check that the required amount of approvals is reached? If this is not supported by bitbucket we should probably contact Atlassian I guess? |
Hey moxli, yeah I think I should ignore approvals by the person that created the pull request. In the future I want to create another I've created #201 to track this issue. |
* added new flags `plan-backend`, `plan-s3-bucket`, `plan-s3-prefix` and deleted `s3-bucket` * interface `plan.Backend` that is implemented by `file` and `s3` * simplified s3 code * didn't end up following my suggestions in runatlantis#30 since storing stuff in metadata requires you to `Get` the object *first* and then use the metadata. By parsing the `Key` to get repo, pull, path, and env, it skips an initial `Get` step, and I can download directly to the correct directory * allow users to specify `application/json` or `application/x-www-form-urlencoded` for the webhook delivery type * remove sending of special header for pull request api (fixes runatlantis#11) Closes runatlantis#30 and runatlantis#17 and runatlantis#11
Issue by @nwalke
Thursday Aug 03, 2017 at 19:23 GMT
Migrated from hootsuite/atlantis#99
Why was it migrated?
Would be awesome to have this support BitBucket
The text was updated successfully, but these errors were encountered: