Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitBucket support #30

Closed
atlantisbot opened this issue Mar 6, 2018 · 13 comments
Closed

BitBucket support #30

atlantisbot opened this issue Mar 6, 2018 · 13 comments
Labels
feature New functionality/enhancement provider/bitbucket

Comments

@atlantisbot
Copy link

Issue by @nwalke
Thursday Aug 03, 2017 at 19:23 GMT
Migrated from hootsuite/atlantis#99
Why was it migrated?


Would be awesome to have this support BitBucket

@atlantisbot
Copy link
Author

Comment by @tomasquith
Monday Aug 07, 2017 at 15:10 GMT


+1

@atlantisbot
Copy link
Author

Comment by @hussfelt
Tuesday Aug 08, 2017 at 19:42 GMT


+1

@atlantisbot
Copy link
Author

Comment by @lkysow
Friday Aug 11, 2017 at 04:58 GMT


Please add a thumbs up reaction so we can keep the comments about the implementation please!

We'll use the reactions to help prioritize.

@atlantisbot
Copy link
Author

Comment by @ashald
Thursday Sep 14, 2017 at 16:24 GMT


We would love to have that! Especially, if it will be possible to use it with self-hosted instances as we have one within internal network.

@lkysow lkysow added the feature New functionality/enhancement label Mar 15, 2018
@MattPumphrey
Copy link

This would be a huge win for our team, as we are currently planning a migration to bitbucket, and are looking to evaluate this tool, but unfortunately as it is not supported we are unable to evaluate this. Is there a timeline on when this is or will be looked at?

@lkysow
Copy link
Member

lkysow commented Jul 16, 2018

Hi @MattPumphrey, I'm going to try and get out an alpha of bitbucket this week. I'll keep you updated and thanks for your interest in Atlantis!

@JeanFred
Copy link

For clarity, would that be about Bitbucket Cloud or Bitbucket Server (aka Stash)? My guess is on the former, but I suggest renaming it for clarity :)

@lkysow
Copy link
Member

lkysow commented Jul 16, 2018

Good question. After looking into it, Bitbucket Cloud uses the 2.0 REST APIs and is deprecating the 1.0 REST APIs while Bitbucket server only uses the 1.0 apis. This means I'll have to develop the two integrations separately.

I think I'll start with Bitbucket Cloud first since there is already a golang client for the 2.0 API. But my intention will be to support both eventually.

@teosoft123
Copy link

+1 Bitbucket is a huge deal for some of us

This was referenced Jul 20, 2018
@lkysow
Copy link
Member

lkysow commented Jul 23, 2018

Atlantis 0.4.3 now supports Bitbucket Cloud (bitbucket.org). To use, run

atlantis server --bitbucket-user $USERNAME --bitbucket-token $TOKEN {other atlantis options}

Bitbucket Server (aka Stash) support is in progress: #190

@lkysow
Copy link
Member

lkysow commented Jul 25, 2018

@aodj @viggeh @arnarg @jkodroff @ilyalavrenov @scboucher @zytek @hussfelt @angry-cellophane @Aerathis @johananl @luvs @jonnydford @MattPumphrey @joestewart @odedpriva @moxli @hubertusa @djenniex @h-svab @JeanFred @frank-bee @leowmjw @adamcrews @kmfk @beatcracker @stibi @nikita-stuzo @teosoft123 @absenth
Bitbucket Cloud and Server are now supported. I'm mentioning you because you 👍'd this issue.

For more information:

If you've got any issues please let me know because it's hard to test out everything. You can join our slack channel here or just post on this ticket.

@moxli
Copy link

moxli commented Jul 26, 2018

@lkysow
First of all thank you very much for adding support for bitbucket! 🥇

I started messing around and tried to use the --require-approval flag.
As stated on your website here the approvals are quite useless right now.

I have set the required approvals to merge a pull request via the Branch permissions to two and started atlantis with the flag.

If approve a pull request on my own and I am able to run apply (atlantis just checks if there is a single approval), how ever I can not merge the pull requests because I need one more person to approve it.

Can you think of any way to make atlantis check that the required amount of approvals is reached? If this is not supported by bitbucket we should probably contact Atlassian I guess?

@lkysow
Copy link
Member

lkysow commented Jul 27, 2018

Hey moxli, yeah I think I should ignore approvals by the person that created the pull request.

In the future I want to create another apply_requirement which is mergeable. Then you could set up the config as you like it, for example requiring 2 approvers.

I've created #201 to track this issue.

nishkrishnan added a commit that referenced this issue Jan 5, 2021
* Add support for fetching gh app user. (#30)

* Upgrade pegomock.

* go mod vendor.
meringu pushed a commit to meringu/atlantis that referenced this issue May 29, 2023
* added new flags `plan-backend`, `plan-s3-bucket`, `plan-s3-prefix` and deleted `s3-bucket`
* interface `plan.Backend` that is implemented by `file` and `s3`
* simplified s3 code
* didn't end up following my suggestions in runatlantis#30 since storing stuff in metadata requires you to `Get` the object *first* and then use the metadata. By parsing the `Key` to get repo, pull, path, and env, it skips an initial `Get` step, and I can download directly to the correct directory
* allow users to specify `application/json` or `application/x-www-form-urlencoded` for the webhook delivery type
* remove sending of special header for pull request api (fixes runatlantis#11)

Closes runatlantis#30 and runatlantis#17 and runatlantis#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement provider/bitbucket
Projects
None yet
Development

No branches or pull requests

7 participants