atlantis running terraform should default to not accepting input

[majormoses]

I got the following:

exit status 1: running "sh -c terraform plan -refresh -no-color -out /opt/atlantis/.atlantis/repos/<REDACTED>/terraform_github/189/default/<REDACTED>/default.tfplan -var atlantis_user=<REDACTED>" in "/opt/atlantis/.atlantis/repos/<REDACTED>/terraform_github/189/default/<REDACTED>"
var.github_token
  export TF_VAR_github_token=$MY_TOKEN

  Enter a value: 
var.github_token
  export TF_VAR_github_token=$MY_TOKEN

  Enter a value: 
var.github_token
  export TF_VAR_github_token=$MY_TOKEN

  Enter a value: 
var.github_token
  export TF_VAR_github_token=$MY_TOKEN

  Enter a value: 

Error: Error asking for user input: missing required value for "github_token"

Asking for input when being run as a user makes a lot of sensu but does not make sense in the context of an automated system such as atlantis. I think we should use input=false by default per: https://www.terraform.io/guides/running-terraform-in-automation.html

Atlantis version: 0.4.5

[lkysow]

Agreed, this change will be easy.