Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of SQL Server for Locking #264

Open
sargun opened this issue Sep 8, 2018 · 5 comments
Open

Usage of SQL Server for Locking #264

sargun opened this issue Sep 8, 2018 · 5 comments
Labels
feature New functionality/enhancement Stale

Comments

@sargun
Copy link

sargun commented Sep 8, 2018

I propose we introduce the usage of using a SQL server for locking.

I propose we do this by adding support for sqlite, and postgresql first.

I propose we do this by introduce the ability to say --locker ${DATABASE_URI} when initializing Atlantis.

I propose that we use https://github.com/xo/dburl to parse the dburls and create the connections. If this URI is blank, we fall back to BoltDB.

I propose that schema management, at least for version 1 of this exercise is outside of the scope, and we add it to documentation on how to create, and / or migrate the schema. Later on, we can add a schema management tool.

Opinions?

@mechastorm
Copy link

I would also like to add that it would be good to also suppose the cloud-native database like AWS DynamoDb. It is not a SQL-based database but service like AWS DynamoDB creates a minimal Ops maintenance overhead.

@sargun
Copy link
Author

sargun commented Sep 11, 2018

@lkysow @anubhavmishra Can I get your blessing before taking this approach / working on this?

@lkysow
Copy link
Member

lkysow commented Sep 11, 2018

Hi @sargun, I'm going to reach out to you to schedule a meeting because this is a large architectural change. Check your email :)

@lkysow lkysow added the feature New functionality/enhancement label Apr 4, 2019
@samcgardner
Copy link

Hi @Ikysow, I'd be interested in implementing this feature or a more general equivalent, could we get in touch?

@lkysow
Copy link
Member

lkysow commented Jun 5, 2019

@samcgardner my comment here #265 (comment) talks about my opinion on this change at the moment. However I'm happy to chat. You can hit me up on the Atlantis Slack?

jamengual pushed a commit that referenced this issue Nov 24, 2022
@dosubot dosubot bot added the Stale label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement Stale
Projects
None yet
Development

No branches or pull requests

4 participants