ImageDocument path and url checking to ensure that the input is really an image #18947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
logan-markewich
approved these changes
Jun 3, 2025
Collaborator
logan-markewich
left a comment
logan-markewich
left a comment
There was a problem hiding this comment.
Very clever. Reading the docs for Pillow, verify seems like a perfect tool for this job
dosubot
bot
added
size:L
Member
Author
|
Not sure at what happened in 3.9 for Weaviate, they say segmentation fault😨 But the tests for what we need seem ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I included two functions to check whether or not an image path or an image url are actually images. It uses PIL so it should be covered by
llama-index-coredependencies without needing to install anything extra.Should fix This Huntr issue
I also added tests to prove the effectiveness of the fix