Skip to content

Using httpx instead of urllib in llama-index-readers-web #18945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Using httpx instead of urllib in llama-index-readers-web #18945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ndex-integrations/readers/llama-index-readers-web/llama_index/readers/web/sitemap/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import urllib.request
import httpx
from typing import List

from defusedxml.ElementTree import fromstring
Expand Down Expand Up @@ -30,9 +30,9 @@ def __init__(self, html_to_text: bool = False, limit: int = 10) -> None:
self._limit = limit

def _load_sitemap(self, sitemap_url: str) -> str:
sitemap_url_request = urllib.request.urlopen(sitemap_url)
sitemap_url_request = httpx.get(sitemap_url)

return sitemap_url_request.read()
return sitemap_url_request.content

def _parse_sitemap(self, raw_sitemap: str, filter_locs: str = None) -> list:
sitemap = fromstring(raw_sitemap)
Expand Down
2 changes: 1 addition & 1 deletion llama-index-integrations/readers/llama-index-readers-web/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dev = [

[project]
name = "llama-index-readers-web"
version = "0.4.1"
version = "0.4.2"
description = "llama-index readers web integration"
authors = [{name = "Your Name", email = "[email protected]"}]
requires-python = ">=3.9,<4.0"
Expand Down
Loading