fix: prevent DoS attacks in JSONReader #18877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
logan-markewich
approved these changes
May 28, 2025
masci
force-pushed
the
massi/max-recursion
branch
from
c6bffff to
7c6b0a6
Compare
masci
commented
May 28, 2025
| self.collapse_length, | ||
| [], | ||
| self.ensure_ascii, | ||
| try: |
Contributor
Author
There was a problem hiding this comment.
There are too many points in this reader where a recursion error can happen. Since the goal is ultimately being defensive against attacks, I think this is the simplest and most robust solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
aan exception handler to avoid hitting Python's recursion limits. This should avoid DoS attacks carried using a deeply nested JSON object.max_depthparameter