llama cloud index revamp #18859
Merged
llama cloud index revamp #18859
+696
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
| ) | ||
| status = status_response.status | ||
| except httpx.HTTPStatusError as e: | ||
| if e.response.status_code in (429, 500, 502, 503, 504): |
Contributor
There was a problem hiding this comment.
Feels like it shouldn't keep hammering our service if there's 5xx? Could exasperate any instability the API may be having.
| self, | ||
| file_path: str, | ||
| verbose: bool = False, | ||
| wait_for_ingestion: bool = True, |
Contributor
There was a problem hiding this comment.
should we rename to wait_for_completion just for consistency with the new method name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamps the
LlamaCloudIndexsignificantlyLlamaCloudIndex.create_index()static function to create an empty indexwait_for_completionllama-cloudSDK