Skip to content

Conversation

@dpernes
Copy link
Contributor

@dpernes dpernes commented May 20, 2025

Description

PR #18781 introduced a bug where tool calls with empty arguments were being skipped (see this comment for a detailed description). This PR fixes it.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 20, 2025
@pazevedo-hyland
Copy link
Contributor

Awesome I think this will also fix this: #18449

@dpernes
Copy link
Contributor Author

dpernes commented May 20, 2025

Awesome I think this will also fix this: #18449

I don't think so, unfortunately. #18449 is a different issue: a ValidationException is (possibly erroneously) raised when the model output contains a tool call without any accompanying text.

Copy link
Member

@AstraBert AstraBert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2025
@AstraBert AstraBert enabled auto-merge (squash) May 20, 2025 13:37
@AstraBert AstraBert disabled auto-merge May 20, 2025 13:37
@AstraBert AstraBert merged commit 0b4e07a into run-llama:main May 20, 2025
9 of 10 checks passed
@colca colca mentioned this pull request Jun 9, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants