Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiModal.HuggingFaceMultiModal: fix errors and README, add stream_complete #16376

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

g-hano
Copy link
Contributor

@g-hano g-hano commented Oct 5, 2024

Description

I added stream_complete support and fixed errors specificly related to Llama3.2 Vision.

Fixes #16368

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 5, 2024
@g-hano g-hano changed the title fix errors and README, add stream_complete MultiModal.HuggingFaceMultiModal: fix errors and README, add stream_complete Oct 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 5, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) October 5, 2024 14:29
@anoopshrma
Copy link
Collaborator

@g-hano could you take a look at linting too!

@logan-markewich logan-markewich merged commit d5b7511 into run-llama:main Oct 8, 2024
11 checks passed
logan-markewich pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants