Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in BasePGRetriever causing graph context to not be added #16357

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

geodavic
Copy link
Contributor

@geodavic geodavic commented Oct 3, 2024

Description

In the _add_source_text() method of BasePGRetriever, there is a mis-named variable that causes the graph content to never be included when creating the source text for a retrieval. This fixes the variable name.

Fixes # (issue)

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense
  • Tested locally

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 3, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) October 3, 2024 18:32
@logan-markewich logan-markewich self-assigned this Oct 3, 2024
@logan-markewich logan-markewich merged commit 72bd52c into run-llama:main Oct 3, 2024
8 of 10 checks passed
jzhao62 pushed a commit to jzhao62/llama_index that referenced this pull request Oct 4, 2024
raspawar pushed a commit to raspawar/llama_index that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants