Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding vertex endpoint embedding #16351

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Conversation

iron8kid
Copy link
Contributor

@iron8kid iron8kid commented Oct 3, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 3, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@iron8kid
Copy link
Contributor Author

iron8kid commented Oct 3, 2024

Hello @logan-markewich,
Could you check this please it is urgent :)
Thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you quickly summarize why this is need when we have VertexTextEmbedding already ? Should we just be updating the existing class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VertexTextEmbedding works only with Vertex models, not with custom models like Hugging Face models deployed on Vertex. Both methods do not use the same invocation process, which is why I added it as a new integration.

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright, I added async, and bumped the dependencies

@logan-markewich logan-markewich self-assigned this Oct 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 3, 2024
@logan-markewich logan-markewich merged commit f1afe25 into run-llama:main Oct 3, 2024
10 checks passed
jzhao62 pushed a commit to jzhao62/llama_index that referenced this pull request Oct 4, 2024
raspawar pushed a commit to raspawar/llama_index that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants